Skip to content

[Kotlin] Added sample using_selenium code#2224

Closed
Tahanima wants to merge 1 commit intoSeleniumHQ:trunkfrom
Tahanima:feature/kotlin-example
Closed

[Kotlin] Added sample using_selenium code#2224
Tahanima wants to merge 1 commit intoSeleniumHQ:trunkfrom
Tahanima:feature/kotlin-example

Conversation

@Tahanima
Copy link
Contributor

@Tahanima Tahanima commented Mar 17, 2025 •
edited by qodo-code-review bot
Loading

User description

Description

This PR adds a sample Kotlin code that can be used to fill missing Kotlin codes in the Organizing and Executing Selenium Code page.

Motivation and Context

I've added the necessary Kotlin file to provide the missing code examples.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Tests

Description

  • Added a new Kotlin test example for Selenium.

  • Demonstrates basic Selenium operations in Kotlin.

  • Includes setup, test execution, and teardown methods.

Changes walkthrough 📝

Relevant files
Tests
UsingSeleniumTest.kt
Add Kotlin test example for Selenium usage                             

examples/kotlin/src/test/kotlin/dev/selenium/getting_started/UsingSeleniumTest.kt

  • Added a Kotlin test class UsingSeleniumTest.
  • Demonstrates Selenium usage with ChromeDriver.
  • Includes a test for form interaction and validation.
  • Implements setup and teardown methods for WebDriver.
    		• +43/-0   
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @netlify
    Copy link

    netlify bot commented Mar 17, 2025 •
    edited
    Loading

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 95bfe8b

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Mar 17, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Deprecated Method

    The code uses the deprecated method getText() on the WebElement. The recommended approach is to use the text property instead.

     
    val value = message.getText()
    Unused Variable

    The variable textBox is redeclared with var but never reassigned. Consider using val instead to make it immutable.

     
    var textBox = driver.findElement(By.name("my-text"))

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Mar 17, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix property access syntax

    In Selenium WebElement, the method to get text is text property in Kotlin, not
    getText(). The current code will likely cause a compilation error.

    examples/kotlin/src/test/kotlin/dev/selenium/getting_started/UsingSeleniumTest.kt [35]

    -val value = message.getText()
+val value = message.text
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    __

    Why: This suggestion fixes a critical issue that would cause a compilation error. In Kotlin, WebElement properties are accessed directly with dot notation rather than using Java-style getter methods.

    		High
    General
    Use immutable reference

    Use val instead of var for the textBox variable since it's not being reassigned
    anywhere in the method. This follows Kotlin best practices of preferring
    immutable references.

    examples/kotlin/src/test/kotlin/dev/selenium/getting_started/UsingSeleniumTest.kt [28]

    -var textBox = driver.findElement(By.name("my-text"))
+val textBox = driver.findElement(By.name("my-text"))
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    __

    Why: Using 'val' instead of 'var' for variables that aren't reassigned is a Kotlin best practice that improves code clarity and prevents accidental reassignment. This is a good style improvement but not critical for functionality.

    		Low
    • Update

    @Tahanima Tahanima force-pushed the feature/kotlin-example branch from 3508ebd to 95bfe8b Compare March 17, 2025 17:54
    @diemol
    Copy link
    Member

    diemol commented Aug 16, 2025 •
    edited
    Loading

    Thank you for your PR but we won't merge it because this content already exists.

    @diemol diemol closed this Aug 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort 1/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @Tahanima @diemol